[Webkit-unassigned] [Bug 84327] [Qt] Make DRT not to dump pixel results if test is layoutTestController.dumpAsText() was called

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84327


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137875|                            |review-
               Flag|                            |




--- Comment #2 from Csaba Osztrogonac <ossy at webkit.org>  2012-04-19 04:30:06 PST ---
(From update of attachment 137875)
View in context: https://bugs.webkit.org/attachment.cgi?id=137875&action=review

Only small nitpicks, otherwise LGTM. Please update the patch and upload it with r?

> Tools/ChangeLog:5
> +        Qt: don't dump pixels if test should be dumped as text
> +
> +        [Qt] don't dump pixels if test should be dumped as text

Could you add the title (the new one, please) only once to the changelog?

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:951
>      // FIXME: All other ports don't dump pixels, if generatePixelResults is false.

Please remove this FIXME, we don't need anymore after your fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.