[Webkit-unassigned] [Bug 81332] Cache support for OpenTypeVerticalData

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81332


Koji Ishii <kojiishi at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137552|0                           |1
        is obsolete|                            |
 Attachment #137552|review?                     |
               Flag|                            |




--- Comment #12 from Koji Ishii <kojiishi at gmail.com>  2012-04-18 22:52:30 PST ---
Created an attachment (id=137841)
 --> (https://bugs.webkit.org/attachment.cgi?id=137841&action=review)
Changed how it removes leading "@" from family name

Sorry for back and forth but after more thoughts, I found one of my claim was invalid.　There are 3 cases here:
1. No leading "@"
2. One leading "@"
3. Two or more leading "@"
99% of the cases run the code for 1. Within the rest of 1%, 99% run the code for 2.
So adding machine cycles to case 1 in order to make case 3 faster doesn't make sense, but adding to case 2 isn't a big deal, especially if it can save from stack overflow on really huge number of leading "@".
I was mistaken between case 1　and 2, sorry about that, and now the new patch uses a loop within case 2 to remove the leading "@". Thank you for the review to find this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.