[Webkit-unassigned] [Bug 80256] Optimize for DARWIN in DirectConvolver::process()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80256





--- Comment #8 from xingnan.wang at intel.com  2012-04-18 19:13:00 PST ---
(From update of attachment 137659)
View in context: https://bugs.webkit.org/attachment.cgi?id=137659&action=review


Updated the patch, thanks.

>> Source/WebCore/platform/audio/DirectConvolver.cpp:88
>> +#if OS(DARWIN)
> 
> Instead of nesting the #if OS(DARWIN) inside of the  #if USE(WEBAUDIO_IPP)
> can we instead use #elif
> 
> #if USE(WEBAUDIO_IPP)
> #elif OS(DARWIN)
> #else
> #endif

Done.

>> Source/WebCore/platform/audio/DirectConvolver.h:40
>> +#endif
> 
> Can we move this include to the .cpp file?

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.