[Webkit-unassigned] [Bug 84302] JSC testing should have complete coverage over typed array types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84302


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137805|review?                     |review+
               Flag|                            |




--- Comment #2 from Geoffrey Garen <ggaren at apple.com>  2012-04-18 17:12:31 PST ---
(From update of attachment 137805)
View in context: https://bugs.webkit.org/attachment.cgi?id=137805&action=review

r=me, with a comment below:

> LayoutTests/fast/js/script-tests/dfg-uint8array.js:109
> +        shouldBe("safeGetter(a, b, c)", "" + safeGetter(checkA, b, c));

Would be nice to put in the actual values of b and c instead of the letters, so it's clearer what went wrong if something goes wrong.

> LayoutTests/fast/js/script-tests/dfg-uint8array.js:136
> +        shouldBe("getter(a, b, c)", "" + safeGetter(a, b));

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.