[Webkit-unassigned] [Bug 83874] [GTK] r114021 triggered media flakyness

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83874





--- Comment #10 from Philippe Normand <pnormand at igalia.com>  2012-04-18 15:27:55 PST ---
(In reply to comment #8)
> (From update of attachment 137687 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137687&action=review
> 
> > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:430
> > +                 "media-playback-requires-user-gesture", FALSE,
> 
> This shouldn't be necessary because both tests *should* call window.internals.settings.setMediaPlaybackRequiresUserGesture(document, false) before ending. Also, I don't believe that any of the other DRT implementations does this cleanup. 
> 

Right. 

> Does the problem reproduce without this?

No, but I don't think it's an issue to keep this line anyway.

I've been trying Simon's patch, after some investigation I think the tests are actually badly calling the InternalSettings API :)

Idl file has: void setMediaPlaybackRequiresUserGesture(in boolean enabled) raises(DOMException);

And the tests do: window.internals.settings.setMediaPlaybackRequiresUserGesture(document, false);

Fixing the tests fixes flakyness here. But I think we still need Simon's patch anyway, maybe in a new bugzilla entry Simon?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.