[Webkit-unassigned] [Bug 80256] Optimize for DARWIN in DirectConvolver::process()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 18 14:39:52 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=80256





--- Comment #6 from Chris Rogers <crogers at google.com>  2012-04-18 14:39:50 PST ---
(From update of attachment 137659)
View in context: https://bugs.webkit.org/attachment.cgi?id=137659&action=review

Seems to sound fine, passes layout tests, etc. just the two nits with the #include and the #if stuff:

> Source/WebCore/platform/audio/DirectConvolver.cpp:88
> +#if OS(DARWIN)

Instead of nesting the #if OS(DARWIN) inside of the  #if USE(WEBAUDIO_IPP)
can we instead use #elif

#if USE(WEBAUDIO_IPP)
#elif OS(DARWIN)
#else
#endif

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list