[Webkit-unassigned] [Bug 84048] ShadowRoot needs resetStyleInheritance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84048


Hajime Morrita <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137623|review?                     |review-
               Flag|                            |




--- Comment #10 from Hajime Morrita <morrita at google.com>  2012-04-18 09:09:41 PST ---
(From update of attachment 137623)
View in context: https://bugs.webkit.org/attachment.cgi?id=137623&action=review

> Source/WebCore/ChangeLog:7
> +        http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#shadow-root-attributes

Could you explain the change itself briefly?

> Source/WebCore/css/CSSStyleSelector.cpp:1638
> +void CSSStyleSelector::applyResetStyleInheritance(MatchResult& result)

This isn't the right approach.
- The flag should affect not only for direct children of the shadow boundary
- Allocating properties for each style resolution is too expensive.

I think this "reset" thing should be handled at where we compute the inheritance in RenderStyle object
because RenderStyle is responsible for style inheritance in WebKit.
You can find such places by seeing the callers of RenderStyle::inheritFrom().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.