[Webkit-unassigned] [Bug 84246] New: [Qt] add LayoutTestController::setPrinting support to Qt unit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84246

           Summary: [Qt] add LayoutTestController::setPrinting support to
                    Qt unit tests
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P3
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: milian.wolff at kdab.com


Created an attachment (id=137699)
 --> (https://bugs.webkit.org/attachment.cgi?id=137699&action=review)
patch that makes the Qt port properly handle setPrinting when creating pixel tests

The Qt port currently has no support for unit tests that rely on LayoutTestController::setPrinting. This bug report should track the effort to add the required bits and pieces.

The attached patch adds handling of LayoutTestController::isPrinting to DumpRenderTreeQt::dump such that it creates PNG files analogous to the other ports. Furthermore a few tests are removed from the Skipped list and their expected baselines are added.

Known Issues:

1) the setPrinting.html test is still Skipped, but when you run it manually with the patch above applied, you get strange results: 
http://imagebin.org/index.php?mode=image&id=207871
- the box is one pixel too high (compare to another platform's expected PNG), notable by the lack of the white 1px line between the blue and green one
- the right border of the box is not painted at all

2) PixelTests need to be run by hand, i.e.:
./Tools/Scripts/run-webkit-tests --print 'everything' -v -p LayoutTests/printing/setPrinting.html

If you'd run it on the whole printing folder, it would also create png-images of test cases that do not expect any image (like e.g. printing/page-break-widows.html). I'll look into this in another bug report.

3) I was unsure on where to add the images to, by default they where created in platform/qt-linux but I hope that they should be the same on all platforms, thanks to the test fonts? Since I was not sure though, I left them in qt-linux for now. If I should move them to qt instead, please tell me.

Cheers

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.