[Webkit-unassigned] [Bug 82930] [BlackBerry] Tab awareness for HTML5 concurrent audio

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82930


George Staikos <staikos at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |staikos at kde.org




--- Comment #24 from George Staikos <staikos at kde.org>  2012-04-18 01:22:24 PST ---
(In reply to comment #23)
> (In reply to comment #22)
> > Files in WebCore/platform should not reference WebCore files outside of platform. 
> 
> That clarifies it partially. But the question remains, which WebCore files am I referencing outside of platform that I'm not supposed to be? The platformPageClient() is in WebKit/blackberry/WebCoreSupport/, not WebCore/.
> 
> 
> > I should have asked - is the test useful for any other port? What does it test in a port that does not restrict the number of audio elements that can play concurrently?
> 
> That makes sense. I don't think the test is very useful even for Blackberry. However patches are not passing review without associated automated layout tests, so I'm just doing what I can to try and shorten the review process.

I don't think this is any worse than the previous code here which was already r+.  However we probably need to think about how to abstract the platform/ code to not call to WebKit/ here.  All that said, this is pretty app-specific for BlackBerry.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.