[Webkit-unassigned] [Bug 83877] [GTK][WK2] Implement geolocation provider for the GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83877





--- Comment #9 from Mario Sanchez Prada <msanchez at igalia.com>  2012-04-18 00:41:44 PST ---
(In reply to comment #2)
> (From update of attachment 137070 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137070&action=review
> 
> We implement C API clients in the API layer, so please move this to UIProcess/API/gtk and implement it the 
> same way we do for other C API clients. Maybe we could move common code to WebCore so that wk1 and 
> wk2 could use the same geolocation provider based on geoclue.

Sorry, I missed this part. Will do that in a follow up patch.

> (In reply to comment #8)
> (In reply to comment #6)
> > Created an attachment (id=137304)
 --> (https://bugs.webkit.org/attachment.cgi?id=137304&action=review) [details] [details]
> > Patch proposal
> 
> What I'm proposing is to wrap geoclue API into a common class in WebCore and use that class from 
> GeolocationClientGtk in wk1 and WebKitGeolocationProvider in wk2. 
> Instead of implementing the C API in UIProcess/gtk, move it to the API layer, adding 
> WebKitGeolocationProvider implemented the same way we implement all other C API clients.

Sounds good to me. That's what I will do

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.