[Webkit-unassigned] [Bug 83254] [EFL] Support for Battery Status API on the WebKit-Efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83254





--- Comment #29 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-04-18 00:07:48 PST ---
(From update of attachment 137198)
View in context: https://bugs.webkit.org/attachment.cgi?id=137198&action=review

>>>>> Source/WebKit/efl/WebCoreSupport/BatteryClientEfl.cpp:48
>>>>> +    ASSERT(e_dbus_init());
>>>> 
>>>> I wonder why do you use ASSERT.
>>> 
>>> I need to check by assertion to confirm init() is working well.
>>> Because init() is failed, battery status api can't work properly.
>> 
>> ASSERT can work on debug build. Do you only need to check it on debug mode?
> 
> Yes, every init() call of efl libraries does not check ASSERT.
> So, I think there is no needs to check on the release build.
> If you want to delete ASSERT, that's no problem to me.

e_dbus_init() returns e_dbus init count when it is failed. So, I think you need to check if e_dbus_init is success.

ewk_main.cpp check it as well.
http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_main.cpp#L80

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.