[Webkit-unassigned] [Bug 82688] Caret is not rendered properly inside an input element with text-indent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82688


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137597|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #12 from Ryosuke Niwa <rniwa at webkit.org>  2012-04-17 13:50:54 PST ---
(From update of attachment 137597)
View in context: https://bugs.webkit.org/attachment.cgi?id=137597&action=review

> Source/WebCore/rendering/RenderBlock.cpp:6501
>      switch (alignment) {
>          case alignLeft:
> +            if (currentStyle->isLeftToRightDirection())
> +                x += textIndentOffset();
>              break;
>          case alignCenter:
>              x = (x + w - (borderRight() + paddingRight())) / 2;
> +            if (currentStyle->isLeftToRightDirection())
> +                x += textIndentOffset() / 2;
> +            else
> +                x -= textIndentOffset() / 2;
>              break;
>          case alignRight:
>              x = w - (borderRight() + paddingRight()) - caretWidth;
> +            if (!currentStyle->isLeftToRightDirection())
> +                x -= textIndentOffset();
>              break;
>      }
> +    x = min(x, w - borderRight() - paddingRight() - caretWidth);

We need to fix this code for vertical writing mode but that's probably a separate bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.