[Webkit-unassigned] [Bug 82301] [EFL] LayoutTestController does not implement callShouldCloseOnWebView

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 17 10:18:20 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82301


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134249|                            |review-
               Flag|                            |




--- Comment #9 from Martin Robinson <mrobinson at webkit.org>  2012-04-17 10:18:20 PST ---
(From update of attachment 134249)
View in context: https://bugs.webkit.org/attachment.cgi?id=134249&action=review

Looks good, just giving an r- because of the funky changelogs.

> LayoutTests/ChangeLog:529
> +2012-03-27  Christophe Dumez  <christophe.dumez at intel.com>
> +
> +        EFL's LayoutTestController does not implement callShouldCloseOnWebView
> +        https://bugs.webkit.org/show_bug.cgi?id=82301
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Implement callShouldCloseOnWebView in EFL's LayoutTestController by

The changelog is in the wrong place here. This will prevent the patch from landing properly with the cq, I think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list