[Webkit-unassigned] [Bug 83030] [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83030


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137484|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #17 from Antonio Gomes <tonikitoo at webkit.org>  2012-04-17 06:49:56 PST ---
(From update of attachment 137484)
View in context: https://bugs.webkit.org/attachment.cgi?id=137484&action=review

it is good to go,with some minor nits.

please reupload with them fixed, and "Reviewed by Antonio Gomes" in the changelogs and only set cq?

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:242
>  Eina_Bool DumpRenderTreeChrome::processWork(void* data)

I think you can omit 'data' or use param_unused

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:259
> +        ecore_idler_add(processWork, 0);

ecore_idler_add(processWork, 0 /*frame*/) maybe would be clearer

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.