[Webkit-unassigned] [Bug 84143] [GTK] Allow to use WebInspector in GtkLauncher

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 17 05:10:40 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=84143


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-04-17 05:10:40 PST ---
Attachment 137517 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/GNUmakefile.am',..." exit_code: 1
Tools/GtkLauncher/LauncherInspectorWindow.c:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Tools/GtkLauncher/LauncherInspectorWindow.c:50:  launcher_inspector_window_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Tools/GtkLauncher/LauncherInspectorWindow.c:56:  launcher_inspector_window_class_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Tools/GtkLauncher/LauncherInspectorWindow.h:44:  launcher_inspector_window_get_type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list