[Webkit-unassigned] [Bug 84018] [GTK][WK2] Implement API for generic permission requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84018





--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-04-17 00:34:29 PST ---
(From update of attachment 137312)
View in context: https://bugs.webkit.org/attachment.cgi?id=137312&action=review

Looks good.

> Source/WebKit2/UIProcess/API/gtk/WebKitPermissionRequest.cpp:29
> + * There are situations where a web browser would need to ask the user

Not all embedders are web browsers

> Source/WebKit2/UIProcess/API/gtk/WebKitPermissionRequest.cpp:33
> + * #WebKitWebVice::permission-request signal with a

WebKitWebVice? :-P

> Source/WebKit2/UIProcess/API/gtk/WebKitPermissionRequest.cpp:40
> + * If the signal handler does nothing, WebKit will act as if
> + * webkit_permission_request_deny() was called as soon as signal
> + * handling completes. To handle a permission request in an
> + * asynchronous way, simply increment the reference count of the
> + * #WebKitPermissionRequest object.

This depends on the implementation, or it should be enforced by the interface.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:656
> +     *

You should mention here that if this signal is not hanlded, the default behaviour is to deny the request

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:661
> +     *

A code snippet here would help to understand how to use this signal

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:146
> +    gboolean   (* permission_request)    (WebKitWebView              *web_view,
> +                                          WebKitPermissionRequest    *permission_request);

There's an extra space before parameter names.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.