[Webkit-unassigned] [Bug 78358] REGRESSION (Safari 5.0.5 - 5.1): Link is not colored as visited if default port number is present

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78358


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137473|review?                     |review-
               Flag|                            |




--- Comment #19 from Eric Seidel <eric at webkit.org>  2012-04-16 21:18:01 PST ---
(From update of attachment 137473)
View in context: https://bugs.webkit.org/attachment.cgi?id=137473&action=review

> Source/WebCore/html/HTMLAnchorElement.h:152
> +        KURL vistedURL = document()->completeURL(fastGetAttribute(HTMLNames::hrefAttr).string());
> +        m_cachedVisitedLinkHash = WebCore::visitedLinkHash(document()->baseURL(), AtomicString(vistedURL.string().utf8().data()));

All these conversions make no sense. :)  You're converting from an AtomicString, to a STring, to a KURL, then to a STring, CSTring, and char* only to go back to an AtomicSTring! :p

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.