[Webkit-unassigned] [Bug 82930] [BlackBerry] Tab awareness for HTML5 concurrent audio

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 16 17:34:42 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82930





--- Comment #21 from Max Feil <mfeil at rim.com>  2012-04-16 17:34:42 PST ---
(In reply to comment #17)
> > Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:115
> > +        tabId = frameView()->hostWindow()->platformPageClient();
> 
> This is a layering violation, code in WebCore/platform should know about code in /page.

Can you please be more specific about the layering violation? Accessing the platformPageClient() via hostWindow() seems to be fairly common in several of the major ports.


> > LayoutTests/ChangeLog:11
> > +        * media/audio-concurrent-supported.html: Added.
> 
> This test looks platform specific. Why is it in the common media test directory?

Can you please be more specific about which part of the test is platform specific? It passes for all major ports.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list