[Webkit-unassigned] [Bug 81332] Cache support for OpenTypeVerticalData

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81332





--- Comment #5 from Kenichi Ishibashi <bashi at chromium.org>  2012-04-16 17:09:01 PST ---
(From update of attachment 135005)
View in context: https://bugs.webkit.org/attachment.cgi?id=135005&action=review

Drive-by comments.

This patch adds massive #ifdefs and I don't think it's a good idea. I think most code added to FontCache can be placed in Source/WebCore/platform/graphics/opentype. For example, you can create a singleton class that manages OpenTypeVerticalData cache or can add static functions to OpenTypeVerticalData. This way you can remove most of #ifdefs except for the one in FontCache::purgeInactiveFontData(). (I'm not sure this function is the right place to do mark & sweep unused verticalData)

> Source/WebCore/platform/graphics/FontCache.cpp:195
> +        return getCachedFontPlatformData(fontDescription, AtomicString(familyName.impl()->substring(1)), checkingAlternateName);

I recommend removing all "@"s in the front name before to avoid unnecessary recursion.

> Source/WebCore/platform/graphics/opentype/OpenTypeVerticalData.h:61
> +    bool m_inFontCache : 1;

Why this filed is a bit-field?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.