[Webkit-unassigned] [Bug 84095] New: Only depend on xrender if x11 is being used

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84095

           Summary: Only depend on xrender if x11 is being used
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
               URL: https://trac.macports.org/ticket/34086
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jeremyhu at apple.com


http://trac.macports.org/ticket/34086

configure.ac contains:
# check for XRender under Linux/Unix. Some linkers require explicit
# linkage (like GNU Gold), so we cannot rely on GTK+ pulling XRender
if test "$os_win32" = "no"; then
   PKG_CHECK_MODULES([XRENDER], [xrender])
   AC_SUBST([XRENDER_CFLAGS])
   AC_SUBST([XRENDER_LIBS])
fi

But that logic is incorrect.  You should be checking for xrender based on target (x11), not OS.  This incorrectly results in xrender being pulled in for the quartz target, and it incorrectly prevents xrender from being pulled in on the win/x11 target.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.