[Webkit-unassigned] [Bug 82930] [BlackBerry] Tab awareness for HTML5 concurrent audio

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82930





--- Comment #17 from Eric Carlson <eric.carlson at apple.com>  2012-04-16 15:02:31 PST ---
(From update of attachment 137402)
View in context: https://bugs.webkit.org/attachment.cgi?id=137402&action=review

> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:115
> +        tabId = frameView()->hostWindow()->platformPageClient();

This is a layering violation, code in WebCore/platform should know about code in /page.

> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:697
> +        rc = frameView()->hostWindow()->platformPageClient()->showAlertDialog(atype);

Ditto.

>> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:728
>> +        return frameView()->hostWindow()->platformPageClient()->isVisible();
> 
> It's a layering violation for code in platform/ to know about code in page/

Ditto.

> LayoutTests/ChangeLog:11
> +        * media/audio-concurrent-supported.html: Added.

This test looks platform specific. Why is it in the common media test directory?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.