[Webkit-unassigned] [Bug 82688] Caret is not rendered properly inside an input element with text-indent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82688





--- Comment #7 from yi shen <yi.4.shen at nokia.com>  2012-04-16 14:43:49 PST ---
Thanks for reviewing.
(In reply to comment #6)
> (From update of attachment 137347 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137347&action=review
> 
> > Source/WebCore/rendering/RenderBlock.cpp:6495
> > +    x = min(x, w - (borderRight() + paddingRight()) - caretWidth);
> 
> This is needed to prevent x from being beyond the edge? Why isn't this needed for the left side as well?
I checked firefox & safari and found both webkit & firefox prevent x from being beyond the right edge only.  
> 
> Also, why not w - borderRight() - paddingRight() - caretWidth? Same with above. Seems less confusing.
I will fix this, thanks :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.