[Webkit-unassigned] [Bug 83254] [EFL] Support for Battery Status API on the WebKit-Efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83254





--- Comment #25 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-04-16 02:31:21 PST ---
(From update of attachment 137198)
View in context: https://bugs.webkit.org/attachment.cgi?id=137198&action=review

As far as I know, webkit coding style declares local variable where it is really used.

> Source/WebKit/efl/WebCoreSupport/BatteryClientEfl.cpp:48
> +    ASSERT(e_dbus_init());

I wonder why do you use ASSERT.

> Source/WebKit/efl/WebCoreSupport/BatteryClientEfl.cpp:49
> +    ASSERT(e_ukit_init());

ditto.

> Source/WebKit/efl/WebCoreSupport/BatteryClientEfl.cpp:116
> +    bool chargingTimeChanged = false;

Move dischargingTimeChagned to line 134.

> Source/WebKit/efl/WebCoreSupport/BatteryClientEfl.cpp:117
> +    bool dischargingTimeChanged = false;

ditto.

> Source/WebKit/efl/WebCoreSupport/BatteryClientEfl.cpp:118
> +    bool levelChanged = false;

Move levelChanged to line 156.

> Source/WebKit/efl/WebCoreSupport/BatteryClientEfl.cpp:122
> +    double level = 0;

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.