[Webkit-unassigned] [Bug 83004] [Plugins] delete ws_info regardless window mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83004


Kwangmin Bang <justine.bang at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137267|1                           |0
        is obsolete|                            |
 Attachment #137267|review-, commit-queue-      |review?, commit-queue?
               Flag|                            |




--- Comment #8 from Kwangmin Bang <justine.bang at samsung.com>  2012-04-16 02:01:08 PST ---
(From update of attachment 137267)
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1863a58..2b59ef9 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2012-04-15  Bang Kwang min  <justine.bang at samsung.com>
>+
>+        [Plugins] delete ws_info regardless of window mode.
>+        https://bugs.webkit.org/show_bug.cgi?id=83004
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        m_npWindow.ws_info should be deleted even if plugin run as windowless mode to remove memory leak.
>+        Every plugin works well after this patch without any crash.
>+        Additionally, change casting syntax to C++ style.
>+
>+        * plugins/PluginView.cpp:
>+        (WebCore::PluginView::stop):
>+
> 2012-04-15  James Robinson  <jamesr at chromium.org>
> 
>         [chromium] LayerRendererChromium shouldn't know anything about CCLayerImpl
>diff --git a/Source/WebCore/plugins/PluginView.cpp b/Source/WebCore/plugins/PluginView.cpp
>index 749f609..389a8fe 100644
>--- a/Source/WebCore/plugins/PluginView.cpp
>+++ b/Source/WebCore/plugins/PluginView.cpp
>@@ -366,8 +366,8 @@ void PluginView::stop()
>     }
> 
> #ifdef XP_UNIX
>-    if (m_isWindowed && m_npWindow.ws_info)
>-           delete (NPSetWindowCallbackStruct *)m_npWindow.ws_info;
>+    if (m_npWindow.ws_info)
>+           delete static_cast<NPSetWindowCallbackStruct *>(m_npWindow.ws_info);
>     m_npWindow.ws_info = 0;
> #endif
>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.