[Webkit-unassigned] [Bug 83879] [GTK][WK2] Implement API for Geolocation permission requests in the GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83879





--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-04-16 01:39:35 PST ---
(From update of attachment 137082)
View in context: https://bugs.webkit.org/attachment.cgi?id=137082&action=review

Please, merge both patches or file separate bug reports.

> Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp:63
> +static void
> +webkit_permission_request_interface_init(WebKitPermissionRequestIface *iface)

This should be a single line and the * is placed wrongly.

> Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp:78
> +    WEBKIT_GEOLOCATION_PERMISSION_REQUEST(object)->priv->~WebKitGeolocationPermissionRequestPrivate();
> +    G_OBJECT_CLASS(webkit_geolocation_permission_request_parent_class)->finalize(object);

You should check here whether request has been made or not, and call deny if it wasn't made. That's what WebKitWebView::permission-request signal documentation says.

> Tools/ChangeLog:9
> +        Make minibrowser connect to the new 'permission requests' signal
> +        to allow users handle the Geolocation permission requests.

Please add unit tests, and maybe leave minibrowser impl for a following patch.

> Tools/MiniBrowser/gtk/BrowserWindow.c:293
> +    GtkWidget *dialog = gtk_dialog_new_with_buttons("Geolocation request",
> +                                                    GTK_WINDOW(window),
> +                                                    GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
> +                                                    GTK_STOCK_OK,
> +                                                    GTK_RESPONSE_ACCEPT,
> +                                                    GTK_STOCK_CANCEL,
> +                                                    GTK_RESPONSE_REJECT,
> +                                                    NULL);

What do you think about using GtkInfoBar instead of a popup dialog?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.