[Webkit-unassigned] [Bug 83877] [GTK][WK2] Implement geolocation provider for the GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83877





--- Comment #3 from Mario Sanchez Prada <msanchez at igalia.com>  2012-04-16 01:25:27 PST ---
(From update of attachment 137070)
View in context: https://bugs.webkit.org/attachment.cgi?id=137070&action=review

Thanks for the review. I'll address all those issues in a follow-up patch.

>> Source/WebKit2/UIProcess/gtk/WebGeolocationProviderGtk.cpp:28
>> +
> 
> Add #if ENABLE(GEOLOCATION) here.

Ok

>> Source/WebKit2/UIProcess/gtk/WebGeolocationProviderGtk.cpp:29
>> +#include "WKGeolocationPosition.h"
> 
> Use angle-bracket form to include WK2 C API headers.

Ok

>> Source/WebKit2/UIProcess/gtk/WebGeolocationProviderGtk.cpp:80
>> +    , m_geocluePosition(0)
> 
> This is already initialized to 0 by GRefPtr

Ok.

>> Source/WebKit2/UIProcess/gtk/WebGeolocationProviderGtk.cpp:118
>> +        m_geocluePosition.clear();
> 
> GRefPtr::clear already checks the pointer before unrefing it, so no need to check it here too.

Ok.

>> Source/WebKit2/UIProcess/gtk/WebGeolocationProviderGtk.cpp:128
>> +    double horizontalAccuracy = 0.0;
> 
> Use 0 instead of 0.0

Ok

>> Source/WebKit2/UIProcess/gtk/WebGeolocationProviderGtk.cpp:138
>> +}
> 
> The error message is ignored.

Ooops! Ok

>> Source/WebKit2/UIProcess/gtk/WebGeolocationProviderGtk.h:22
>> +
> 
> Add #if ENABLE(GEOLOCATION) here

Ok

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.