[Webkit-unassigned] [Bug 83004] [Plugins] delete ws_info regardless window mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83004


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137267|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Simon Hausmann <hausmann at webkit.org>  2012-04-16 01:07:38 PST ---
(From update of attachment 137267)
View in context: https://bugs.webkit.org/attachment.cgi?id=137267&action=review

Looks good in general, but I think you can remove the if() altogether and there are a few language nitpicks :)

> Source/WebCore/ChangeLog:3
> +        [Plugins] delete ws_info regardless window mode.

"regardless window mode" -> "regardless of the window mode"

> Source/WebCore/ChangeLog:10
> +        Additionally, change casting synta to C++ style.

synta -> syntax

> Source/WebCore/plugins/PluginView.cpp:370
> +    if (m_npWindow.ws_info)
> +           delete static_cast<NPSetWindowCallbackStruct *>(m_npWindow.ws_info);

I don't think the if() is needed at all. delete 0 is perfectly valid C++.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.