[Webkit-unassigned] [Bug 83007] [EFL] EFL's LayoutTestController overridePreference implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83007





--- Comment #10 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2012-04-16 00:56:41 PST ---
(In reply to comment #9)
> (From update of attachment 137249 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137249&action=review
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:212
> > +        bool hyperlinkAuditingEnabled : 1;
> 
> I'm not sure whether we need to add new API for hyperlinkAuditing setting. Are you sure ?
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:222
> > +        bool tabsToLinks : 1;
> 
> ditto.
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:223
> > +        bool webGLEnabled : 1;
> 
> We already have compile option for WebGL. When do we need to turn on/off webgl dynamically ?

Another solution could be off course to put these settings to DumpRenderTreeSupportEfl(just for enabling LayoutTestController overridePreference), however 
these settings are exported in other ports: GTK, Qt, mac, win, so 
I decided to keep efl port consistent with other ones.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.