[Webkit-unassigned] [Bug 18638] Add support for non X11 unix platforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 15 21:47:46 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=18638


Stuart Morgan <stuartmorgan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stuartmorgan at chromium.org




--- Comment #9 from Stuart Morgan <stuartmorgan at chromium.org>  2012-04-15 21:47:46 PST ---
(In reply to comment #7)
> So is there a policy on how often Webkit updates NPAPI headers ?
> Or should i just pull that file from npapi-SDK and submit as a patch for review ?

The reason you see divergence is that the npapi-sdk project is quite new in the history of NPAPI; until recently, there was no single source, and each browser vendor had their own copies of the headers that had diverged a fair amount. Work has been done to bring WebKit much closer to the new upstream header, but it was never finished (see bug 38666, bug 77200, and the various bugs they reference).

I'd recommend strongly against trying to check in the upstream headers directly as a single patch, and instead pick out the differences specifically related to the MOZ_X11 guard and reconcile just those in one patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list