[Webkit-unassigned] [Bug 72841] NRWT: option --skip-pixel-test-if-no-baseline support on DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72841





--- Comment #29 from Nandor Huszka <hnandor at inf.u-szeged.hu>  2012-04-13 01:20:34 PST ---
(In reply to comment #28)
> (From update of attachment 136656 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=136656&action=review 
> I don't think I have all the unit tests I need yet to make sure mock_drt doesn't break, but I'd be curious to know if mock_drt_unittest.py actually passes with this change? You should also do something like 'run-webkit-tests --platform mock-mac-lion' and 'run-webkit-tests --platform mock-gtk' and make sure the script runs to completion without any crashes or anything else weird happening.

You are right, these commands fail with this error:
File "/home/hnandor/WebKit/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 545, in run_test
    self._driver.start(self._port.get_option('pixel_tests'), [])
AttributeError: 'GtkDriver' object has no attribute '_driver'

But I do not understand why the system is missing the _driver member. I did not removed it, is this because of this
> 
> > Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py:188
> > +            is_reftest = driver_input.should_run_pixel_test
> 

modification in your opinion? I do not have any idea for it, what could we do?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.