[Webkit-unassigned] [Bug 83777] Introduce MenuItemID to autofill popup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83777


Keishi Hattori <keishi at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-unassigned at lists.web |keishi at webkit.org
                   |kit.org                     |
 Attachment #137054|0                           |1
        is obsolete|                            |
 Attachment #137054|review?                     |
               Flag|                            |
 Attachment #137056|                            |review?
               Flag|                            |




--- Comment #7 from Keishi Hattori <keishi at webkit.org>  2012-04-13 01:08:55 PST ---
Created an attachment (id=137056)
 --> (https://bugs.webkit.org/attachment.cgi?id=137056&action=review)
Fixed mistake

> (From update of attachment 136895 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=136895&action=review
> 
> > Source/WebKit/chromium/public/WebAutofillClient.h:43
> > +    enum {
> 
> nit: we usually name enums, and then we use the enum name
> as the typename elsewhere.
> 
> shouldn't didAcceptAutofillSuggestion use a named enum type
> for the itemID parameter?
> 
> please also see:
> http://trac.webkit.org/wiki/ChromiumWebKitAPI#Enums

Positive itemID are unique ids used to identify the autofill item. And the enum values are used for zero and negative itemIDs.

@fishd should I still use the enum name?

> > Source/WebKit/chromium/public/WebView.h:364
> > +        const WebVector<int>& itemIDs) = 0;
> 
> Chrome doesn't yet call this function?  It is easy to land without breaking Chrome?

I added a default value to the argument I want to remove, so we can transition without breaking the build.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.