[Webkit-unassigned] [Bug 83227] [chromium] wrong justification for arabic/persian page in cr-win

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83227





--- Comment #40 from Xiaomei Ji <xji at chromium.org>  2012-04-13 00:03:53 PST ---
(In reply to comment #39)
> > According to the blog post mentioned in the comment, the patch looks good. However, I'm not sure how this work and worry about regressions. Did you confirm that the patch doesn't cause any regression by running new-run-layout-tests?
> 
> I tried ran run_webkit_tests.bat locally which hangs if I did not run test manually one-by-one.
> I tried to submit the CL to chromium's win_layout try bot, but that try bot is unmaintained and it is always failed in update.
> 
> Also, it is very weird that I am not able to generate png for the previous failed test -- atsui-spacing-features.html. I use the same command, and it could generate the png result for other tests I tried. But "./run_webkit_tests.bat --debug --pixel-tests fast/text/atsui-spacing-features.html" reported "1 tests ran as expected" locally (without comparing pixel result).
> 
> I will try new-run-layout-tests in windows.

Theoretically, the patch should work. For non-arabic page, it should do things as before. As to arabic page that triggers kashida justification, we turned it off. The previous patch has problem of not exactly justifying text, because I use paddingPerSpace = additionalSpace / numOfSpaces, if additionalSpace % numOfSpaces != 0, it is not fully justified. It should be able to further tune. But I think using Window's native should works better and consistent with previous behavior.

I tried run run_webkit_tests.bat (http://www.chromium.org/developers/testing/webkit-layout-tests). Seems that it hangs on those failed test in Windows (specified in test_expectations.txt). So, I only ran those tests under fast/text that having 'justify' style specified (exclude the 6 failed tests that cause run_webkit_tests hang). They pass.

Tried following http://dev.chromium.org/developers/contributing-to-webkit in Windows, but I got a lot of missing file warning when running "update-webkit --chromium'. And I am giving it up.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.