[Webkit-unassigned] [Bug 83721] Framesniffing defense is too aggressive.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83721





--- Comment #7 from Thomas Sepez <tsepez at chromium.org>  2012-04-12 14:58:04 PST ---
> Could we instead clear this flag with a call in FrameLoader::scrollToFragmentWithParentBoundary after view->scrollToFragment() ?

That is much cleaner, and I thought about doing it that way.  But here's why I held off

There's a case in FrameView::maintainScrollPositionAtAnchor() where we take a detour into Layout() rather than falling into the (no-argument form of) FrameView::ScrollToAnchor().  It wasn't clear to me how long this path would postpone the actual scroll.  Could it return to FrameLoader, clear the flag (in your proposal), and then have the scroll implied by the anchor fire some time later (like after some other style sheet load)?


Also, I wanted to log a console message (once) when this occurs, so that anyone opening the error console would know this is deliberate (vs. a silent breakage).  I got the feeling that logging from something like RenderLayer would be seriously frowned upon.  How to arrange for that to happen?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.