[Webkit-unassigned] [Bug 83811] New: Stop exposing RenderLayer knowledge to the code outside rendering/

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 12 13:17:53 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=83811

           Summary: Stop exposing RenderLayer knowledge to the code
                    outside rendering/
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jchaffraix at webkit.org
                CC: simon.fraser at apple.com, jamesr at chromium.org
        Depends on: 83728


Currently RenderLayer's getter is public (RenderBoxModelObject::layer()) which makes it convenient for people to start poking the layer. However this is hurting us as objects outside rendering have some very deep knowledge of how rendering is supposed to work. This breaks the rendering abstraction and makes it harder to refactor RenderLayer in many ways.

I haven't thought deeply on that but RenderObject::hasLayer() should likely be made protected too as this is an implementation detail.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list