[Webkit-unassigned] [Bug 83692] [EFL] Add API for color chooser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83692





--- Comment #9 from Thiago Marcos P. Santos <tmpsantos at gmail.com>  2012-04-12 10:01:24 PST ---
(In reply to comment #7)
> (From update of attachment 136918 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=136918&action=review
> 
> Looks mostly fine. I wonder if it wouldn't make sense to pass the color data as a struct to the users; otherwise, the documentation should at least mention how to extract the RGBA values from the integer (and note that it's encoded as ARGB instead of RGBA). 

Hmmm... good point. I'm going to change to structure as you are suggesting since Evas always handles color as 4 separated bytes.

> Is there any test that can be unskipped?

There are some tests related to color input that are already succeeding but are unrelated to this patch. I going to unskip them on a different patch, otherwise is misleading.

> 
> Last but not least: do you know if the BlackBerry port does something similar to us (ie. relay a signal and leave it up to the user to create the color chooser)? I'm thinking how an actual implementation would work -- one would probably need the position where the event was emitted to create the widget, for example.

My implementation is based on the Chromium port, that doesn't delivery any kind of positioning coordinates (IMO because they assume the current mouse coordinates). For BlackBerry port this should not matter, since I guess it will open a fullscreen window on the mobile device.

> 
> > Source/WebCore/platform/efl/ColorChooserEfl.h:51
> > +    ChromeClientEfl *m_chromeClient;
> 
> Style nitpick: wrong placement of the asterisk.

Your eyes are better than the style-checker. Thanks for reviewing. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.