[Webkit-unassigned] [Bug 83692] [EFL] Add API for color chooser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83692





--- Comment #7 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-04-12 09:12:56 PST ---
(From update of attachment 136918)
View in context: https://bugs.webkit.org/attachment.cgi?id=136918&action=review

Looks mostly fine. I wonder if it wouldn't make sense to pass the color data as a struct to the users; otherwise, the documentation should at least mention how to extract the RGBA values from the integer (and note that it's encoded as ARGB instead of RGBA). Is there any test that can be unskipped?

Last but not least: do you know if the BlackBerry port does something similar to us (ie. relay a signal and leave it up to the user to create the color chooser)? I'm thinking how an actual implementation would work -- one would probably need the position where the event was emitted to create the widget, for example.

> Source/WebCore/platform/efl/ColorChooserEfl.h:51
> +    ChromeClientEfl *m_chromeClient;

Style nitpick: wrong placement of the asterisk.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.