[Webkit-unassigned] [Bug 83701] Web Inspector: Move meta node out of nodes in snapshot serialization.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83701





--- Comment #4 from Yury Semikhatsky <yurys at chromium.org>  2012-04-12 05:25:40 PST ---
(From update of attachment 136683)
View in context: https://bugs.webkit.org/attachment.cgi?id=136683&action=review

>>> Source/WebCore/inspector/front-end/HeapSnapshot.js:159
>>> +            delete this._snapshot.snapshot.meta;
>> 
>> Instead of assigning it to a new variable on this._snapshot you can leave "meta" node and access it later using  this._snapshot.snapshot.meta, what's wrong with that?
> 
> Nothing wrong, it's just longer and I have to update it in several places. Do you insist?

this._snapshot.metaNode is not much shorter than this._snapshot.snapshot.meta but requires additional processing of input data, and anyway you can use a local alias if a name feels long.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.