[Webkit-unassigned] [Bug 83758] Web Inspector: Node Value should not get corrupt while jump over different matches in search.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 12 03:47:35 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=83758





--- Comment #6 from sam <dsam2912 at gmail.com>  2012-04-12 03:47:35 PST ---
(In reply to comment #4)
> (From update of attachment 136861 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=136861&action=review
> 
> > Source/WebCore/inspector/front-end/ElementsTreeOutline.js:640
> > +        if (show) {
> 
> Since this now falls into two branches, it would be better to remove the |updater| var (which was introduced to avoid branching) altogether and call updateEntryShow and updateEntryHide directly in the branches instead.

Thank you Alexander for review! I have uploaded the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list