[Webkit-unassigned] [Bug 83748] [Chromium] Remove existing markers when updating markers.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 12 02:28:50 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=83748





--- Comment #8 from Hajime Morrita <morrita at google.com>  2012-04-12 02:28:49 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > Even though this is just a random thought, one option is splitting didCheck into two functions: didCheckSucceeded() and didCheckFailed(). In the current usage of Chrome, Chrome calls this function for a couple of purposes: notifying Chrome finishes the given text-check request successfully and notifying Chrome has an error while processing the request. Chrome needs to erase existing markers only when it finishes checking text successfully. On the other hand, Chrome should not erase existing markers when it fails checking the text. Would it be possible to give me your thoughts about this idea?
> 
> That makes sense to me at least. Maybe jpu and morrita have some opinions here?
Sounds making sense to me either.
If didCheckFailed() implies leaving the marker, something like didCheckCancel could be a better name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list