[Webkit-unassigned] [Bug 83720] [Qt][WK2] Nested fixed elements scroll too fast

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83720


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136766|review?                     |review-
               Flag|                            |




--- Comment #3 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-04-11 15:42:48 PST ---
(From update of attachment 136766)
View in context: https://bugs.webkit.org/attachment.cgi?id=136766&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:525
> +    TextureMapperLayer* parent = m_parent;
> +    while (parent && !parent->m_fixedToViewport)
> +        parent = parent->m_parent;
> +
> +    if (parent)
> +        return;

Strange traversal...
How about a function isAncestorFixedToViewport() that returns true/false, and this function calling it?

> Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp:364
> +    if (m_fixedLayers.isEmpty())
> +        return;
> +
> +    LayerMap::iterator end = m_fixedLayers.end();
> +    for (LayerMap::iterator it = m_fixedLayers.begin(); it != end; ++it)
> +        toTextureMapperLayer(it->second)->setFixedToViewport(true);

This seems like a different bug/fix?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.