[Webkit-unassigned] [Bug 83612] Split CSSStyleSheet into internal and CSSOM type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83612


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136708|review?                     |review-
               Flag|                            |




--- Comment #16 from Andreas Kling <kling at webkit.org>  2012-04-11 12:07:57 PST ---
(From update of attachment 136708)
View in context: https://bugs.webkit.org/attachment.cgi?id=136670&action=review

> Source/WebCore/css/CSSStyleSheet.cpp:510
> +        m_childRuleCSSOMWrappers[index]->setParentStyleSheet(0);

We're gonna need a null check here, since this particular wrapper may not have been instantiated.

> Source/WebCore/dom/ProcessingInstruction.cpp:240
> +    else if (m_isXSL)
> +        static_cast<XSLStyleSheet*>(m_sheet.get())->parseString(sheet, CSSStrictMode);

This looks silly, XSLStyleSheet shouldn't be taking a CSSParserMode.

> Source/WebCore/xml/XSLStyleSheet.h:74
> +    virtual bool isLoading() const;

Should add OVERRIDE while we are touching this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.