[Webkit-unassigned] [Bug 83583] test-webkitpy fails on metered_stream_unittest for non-US West Coast Time Zones

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83583





--- Comment #8 from Simon Pena <spena at igalia.com>  2012-04-11 07:02:31 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > Do you recall anything in this tests configuration (or in the test runner) that
> > could prevent time.tzset() from working?
> 
> Nope, we generally don't do anything with timezones. I can take a look at
> it if I get a chance.

I took a look at this, and found that
- if we update TZ envvar in test-webkitpy or the Tester, the unit test runs in
  the timezone we expect and works fine.
- if we update the TZ envvar in the unit test, time.tzset() ignores it, and stays
  in my system's timezone.

I checked what's going on with the environment, and it looks that in
webkitpy/layout_tests/port/webkit.py, we run the tests with a copy of the
environment (check _run_script method).

Am I getting it right? Is there a way to modify the environment for a given test
so time.tzset() gets it?

Updating the TZ envvar on the Tester or the test-webkitpy script is trivial,
but I'm afraid it could be forgotten there and cause issues in other tests later.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.