[Webkit-unassigned] [Bug 80978] [BlackBerry] MMRPlayer will hang webkit thread when retrieving media metadata

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80978





--- Comment #8 from Jonathan Dong <jonathan.dong at torchmobile.com.cn>  2012-04-10 19:49:23 PST ---
(From update of attachment 136391)
View in context: https://bugs.webkit.org/attachment.cgi?id=136391&action=review

>> Source/WebCore/ChangeLog:13
>> +        block the webkit thread as what we used to do in platform repo.
> 
> please rephrase the last sentence, it is not completely clear to me what you mean.

Thanks Rob, What I'm trying to say is according to our old implementation in platform repo, we hang the webkit thread to wait for metadata thread to finish, the codes lie inside the class BlackBerry::Platform::MMRPlayer::mmrConnect. This patch is part of the fix for this issue, the other part of fix in platform repo has already get reviewed by Max and will push into the trunk together with this one when done.
As this sentence is kind of confusing, and the former words already described the function of this patch, so I intend to remove it in the next patch.

>> LayoutTests/http/tests/media/video-throttle-load-metadata.html:32
>> +            video.src = "http://127.0.0.1:8000/media/video-throttled-load.cgi?name=" + movie + "&throttle=400&type=video/mp4";
> 
> "type=video/mp4" isn't necessarily correct. findMediaFile() will return a file that the current port can load, which may not be MPEG-4. You should use something like "mimeTypeForExtension(movie.split('.').pop())" instead.

Thanks Eric, will fix it with the next patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.