[Webkit-unassigned] [Bug 71662] [GTK] media/event-attributes.html fails

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 10 16:37:14 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=71662





--- Comment #14 from Dirk Pranke <dpranke at chromium.org>  2012-04-10 16:37:14 PST ---
(From update of attachment 136439)
View in context: https://bugs.webkit.org/attachment.cgi?id=136439&action=review

> Tools/Scripts/webkitpy/layout_tests/port/gtk.py:60
> +        if self._worker_number == 0:

Why are you doing this change here at all, and why checking if _worker_number == 0? 

If you want this to happen before *any* tests are run (and reset after *all* of them have run), you should do this work in GtkPort.setup_test_run (and it looks like there isn't a corresponding clean_up_test_run(), so we should probably add that and add the call in Manager._clean_up_run in manager.py.

On the other hand, if you want to do this for each individual test, it's not clear to me how this would work when running multiple DRTs simultaneously?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list