[Webkit-unassigned] [Bug 83411] All Mac bots occasionally fail tons of media/ sputnik/ and svg/ tests

Tue Apr 10 13:03:30 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=83411





--- Comment #12 from Antonio Gomes <tonikitoo at webkit.org>  2012-04-10 13:03:30 PST ---
I wonder if the above patch fixes things. We would have to unskip the test again and wait for a few bot cycles.

Anyways, the changes below work fine on Gtk and Qt builds, and should go it regardless I would say.

diff --git a/LayoutTests/media/nodesFromRect-shadowContent.html b/LayoutTests/media/nodesFromRect-shadowContent.html
index d55610a..9fdaf7f 100644
--- a/LayoutTests/media/nodesFromRect-shadowContent.html
+++ b/LayoutTests/media/nodesFromRect-shadowContent.html
@@ -13,11 +13,6 @@
   <script type="text/javascript" charset="utf-8">
     function runTest()
     {
-      if (window.layoutTestController) {
-        layoutTestController.dumpAsText();
-        layoutTestController.waitUntilDone();
-      }
-
       var e = {};

       // Set up shortcut access to elements
@@ -42,12 +37,7 @@

       var shadow =['-webkit-media-controls-timeline-container', '-webkit-media-controls-play-button', '-webkit-media-controls-panel', '-webkit-media-controls'];
       checkShadowContent(clickX, clickY, 10, 10, 20, 20, shadow);
-
-      if (window.layoutTestController)
-        layoutTestController.notifyDone();
     }
-
-    window.onload = runTest;
   </script>
 </head>
 <body id="body">
@@ -58,6 +48,7 @@
         testExpected("video.controls", null, '!=');
         waitForEvent('canplaythrough', function () {
             runTest();
+            endTest();
         } );
         video.src = findMediaFile("video", "content/test");
     </script>
diff --git a/LayoutTests/platform/gtk/media/nodesFromRect-shadowContent-expected.txt b/LayoutTests/platform/gtk/media/nodesFromRect-shadowContent-expected.txt
index 390e73e..371f393 100644
--- a/LayoutTests/platform/gtk/media/nodesFromRect-shadowContent-expected.txt
+++ b/LayoutTests/platform/gtk/media/nodesFromRect-shadowContent-expected.txt
@@ -4,4 +4,5 @@ This test only runs in DRT!

 EXPECTED (video.controls != 'null') OK
 EVENT(canplaythrough)
+END OF TEST

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

