[Webkit-unassigned] [Bug 83565] Crash when reloading page while it is loading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83565


Nate Chapin <japhet at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136433|review?                     |review-
               Flag|                            |




--- Comment #6 from Nate Chapin <japhet at chromium.org>  2012-04-10 09:39:40 PST ---
(From update of attachment 136433)
View in context: https://bugs.webkit.org/attachment.cgi?id=136433&action=review

> Source/WebCore/loader/ResourceLoader.cpp:385
> -
> -        m_documentLoader->cancelPendingSubstituteLoad(this);
> +        if (m_documentLoader)
> +            m_documentLoader->cancelPendingSubstituteLoad(this);

We don't typically null-check ResourceLoader::m_documentLoader. The preferred technique is to check m_reachedTerminalState, which should catch every case where m_documentLoader is null.

It would be great if we had a layout test for this. At the very least, we should figure out where in here we're calling releasedResources(), which nulls m_documentLoader and sets m_reachedTerminalState to true.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.