[Webkit-unassigned] [Bug 71662] [GTK] media/event-attributes.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71662





--- Comment #12 from Martin Robinson <mrobinson at webkit.org>  2012-04-10 08:05:23 PST ---
(From update of attachment 136439)
View in context: https://bugs.webkit.org/attachment.cgi?id=136439&action=review

>> Tools/Scripts/webkitpy/layout_tests/port/gtk.py:65
>> +        # We want to unload pulseaudio's module-stream-restore, since it
>> +        # remembers volume settings from different runs, and could affect
>> +        # multimedia tests results
>> +        if self._worker_number == 0:
>> +            with open(os.devnull, 'w') as devnull:
>> +                pactl_process = subprocess.Popen(["pactl", "list", "short", "modules"], stdout=subprocess.PIPE, stderr=devnull)
>> +            modules_list = pactl_process.communicate()[0]
>> +            self._module_index = -1
>> +            for module in modules_list.split('\n'):
> 
> Please use splitlines()

It makese sense to split this off into a helper method.

> Tools/Scripts/webkitpy/layout_tests/port/gtk.py:81
> +        # If pulseaudio's module-stream-restore was previously loaded, we
> +        # restore it here.
> +        if self._worker_number == 0 and self._module_index != -1:
> +            with open(os.devnull, 'w') as devnull:
> +                subprocess.Popen(["pactl", "load-module", "module-stream-restore"], stdout=devnull, stderr=devnull)

Is there a way to disable this for a single process only, so we can avoid putting the system in a bad state if the process crashes?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.