[Webkit-unassigned] [Bug 83349] [BlackBerry] We shouldn't set empty Content-Length & Content-Type to request's headers.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 9 19:16:21 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=83349





--- Comment #5 from Leo Yang <leo.yang at torchmobile.com.cn>  2012-04-09 19:16:21 PST ---
(From update of attachment 135979)
View in context: https://bugs.webkit.org/attachment.cgi?id=135979&action=review

OK, let's keep consistent with clearHTTPReferrer. Looks good to me.

>>> Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:210
>>> +    m_httpHeaderFields.remove("Content-Length");
>>> +
>>> +    if (url().protocolInHTTPFamily())
>>> +        m_platformRequestUpdated = false;
>> 
>> Just ASSERT(url().protocolInHTTPFamily()) instead of *if* branch?
> 
> Why don't we do as clearHTTPReferrer? 
> If we remove this *if* branch, "updateResourceRequest();" can be moved, too.

Just ASSERT(url().protocolInHTTPFamily()) instead of *if* branch?

>> Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:220
>> +    m_httpHeaderFields.remove("Content-Type");
>> +
>> +    if (url().protocolInHTTPFamily())
>> +        m_platformRequestUpdated = false;
> 
> Ditto.

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list