[Webkit-unassigned] [Bug 82617] prevent page breaks in table rows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82617


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #9 from Dave Hyatt <hyatt at apple.com>  2012-04-09 17:54:14 PST ---
Leaving more notes for myself.... the basic issue is we need to add support for pagination struts to tables. The pagination strut propagation gets stopped at the table cell, and we need to propagate it outwards and then use that as a means of pushing cells themselves (I think it's better to have struts pushed per-cell, even if it means cells inside a row have varying heights and alignments of the cell borders.)

Here's the relevant snippet from RenderBlock.cpp:

if (paginationStrut) {
        // We are willing to propagate out to our parent block as long as we were at the top of the block prior
        // to collapsing our margins, and as long as we didn't clear or move as a result of other pagination.
        if (atBeforeSideOfBlock && oldTop == result && !isPositioned() && !isTableCell()) {

Note the !isTableCell() check. We need to remove this and get struts properly stored for cells and then patch table layout to handle what to do when a cell has a strut (probably in RenderTableSection::layoutRows).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.