[Webkit-unassigned] [Bug 81221] Expose attack, release as DynamicsCompressorNode's attributes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81221





--- Comment #26 from Chris Rogers <crogers at google.com>  2012-04-09 16:57:17 PST ---
(In reply to comment #25)
> Created an attachment (id=136328)
 --> (https://bugs.webkit.org/attachment.cgi?id=136328&action=review) [details]
> Fix DynamicsCompressorNode idl issue with ObjC release() method.
> 
> This is a very minimal patch that fixes the release() issue with the DynamicsCompressorNode idl.  I did not copy SkipAttribute() from CodeGeneratorsGObject.pm and Kentaro suggested.  That didn't work for me and caused an error about a change in the public API of HMLEElement.  I stripped it down to the bare minimum to remove the conflict with release().
> 
> Please review this and let me know if this is the correct approach; I'm not at all familiar with these scripts to generate the bindings.

Raymond, it looks like you forgot to include the original changes along with your build fix.  Please re-upload patch.

Also, did you check that the .release attribute is actually exposed in the DynamicsCompressorNode on the mac port?  It should be pretty easy to check by setting a break-point on a sample which creates this node (granular.html for example) and looking at the JS object in the developer tools inspector.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.